On 24/03/15 16:33, Andres Freund wrote:
> Hi,
>
> Here's the next version of this patch. I've tried to address the biggest
> issue (documentation) and some more. Now that both the more flexible
> commit WAL record format and the BKI_FORCE_NOT_NULL thing is in, it
> looks much cleaner.
>
Nice, I see you also did the more close integration with CommitTs. I
only skimmed the patch but so far and it looks quite good, I'll take
closer look around end of the week.
>
> I'd greatly appreciate some feedback on the documentation. I'm not
> entirely sure into how much detail to go; and where exactly in the docs
> to place it. I do wonder if we shouldn't merge this with the logical
> decoding section and whether we could also document commit timestamps
> somewhere in there.
Perhaps we should have some Logical replication developer documentation
section and put all those three as subsections of that?
-- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services