Re: [HACKERS] [PATCH] Assert that the correct locks are held when calling PageGetLSN()

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: [HACKERS] [PATCH] Assert that the correct locks are held when calling PageGetLSN()
Дата
Msg-id 54864083-16D3-4D65-851C-43C26830BA21@yesql.se
обсуждение исходный текст
Ответ на Re: [HACKERS] [PATCH] Assert that the correct locks are held whencalling PageGetLSN()  (Jacob Champion <pchampion@pivotal.io>)
Список pgsql-hackers
> On 20 Sep 2017, at 00:29, Jacob Champion <pchampion@pivotal.io> wrote:
>
> On Wed, Sep 6, 2017 at 8:37 AM, Jacob Champion <pchampion@pivotal.io> wrote:
>> On Tue, Sep 5, 2017 at 10:49 PM, Michael Paquier
>> <michael.paquier@gmail.com> wrote:
>>> In short, it seems to me that this patch should be rejected in its
>>> current shape.
>>
>> Is the half of the patch that switches PageGetLSN to
>> BufferGetLSNAtomic correct, at least?
>
> Any further thoughts on this? If the BufferGetLSNAtomic fixes made
> here are not correct to begin with, then the rest of the patch is
> probably moot; I just want to double-check that that is the case.

Based on the discussions in this thread, I’m marking this patch Returned with
feedback. Please re-submit a new version in an upcoming commitfest when ready.

cheers ./daniel

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Emre Hasegeli
Дата:
Сообщение: Re: [HACKERS] [PATCH] Improve geometric types
Следующее
От: Daniel Gustafsson
Дата:
Сообщение: Re: [HACKERS] Making clausesel.c Smarter