Re: BUG #11949: pg_basebackup creates defective tar file

On 12/04/2014 10:24 AM, Heikki Linnakangas wrote:
> The "too many bits in the mode field" problem seems to be that we store
> the file type bits that stat(2) returns in st_mode & ST_IFMT, in the
> archive's mode field, while the ustar file format only expects the
> permission bits to be there. Tar program will ignore the extra bits,
> which is why we haven't noticed, but I guess we should fix that anyway,
> for the sake of cleanliness. But that's not the root cause of the
> --append corruption.

Ok, pushed a patch to mask out the extraneous bits in the file mode
field. I only pushed it to git master, since this hasn't caused any
problems in practice.

- Heikki