On 11/25/2014 11:46 PM, Michael Paquier wrote:
> Hi all,
>
> In the stuff I work on in a daily basis there are a couple of
> extensions written in C++, compiling them with MSVC on Windows using
> slightly-different scripts available in src/tools after copying them
> directly in contrib/. However, the build scripts available in
> src/tools/msvc are not able to detect files suffixed as cpp or
> similar. Attached is a two-line patch that enables their detection. I
> believe this would be useful for packagers on Windows.
>
+ unless ($fileNameWithPath =~ /^(.*)\\([^\\]+)\.[r]?[cyl](pp)?$/);
This doesn't seem to me to be terribly well expressed (I know it's not your fault, quite possibly it's mine.) Perhaps
weshould replace
[r]?[cyl](pp)?
with
(c|cpp|y|l|rc)
which I think is what's intended, and seems much less obscure to me.
cheers
andrew