Re: Add shutdown_at_recovery_target option to recovery.conf

On 19/11/14 17:04, Simon Riggs wrote:
> On 19 November 2014 15:57, Andres Freund <andres@2ndquadrant.com> wrote:
>> On 2014-11-19 15:47:05 +0000, Simon Riggs wrote:
>>>> Also, for the Shutdown itself, why are we not using
>>>>     kill(PostmasterPid, SIGINT)?
>>>
>>> Done
>>
>> I don't think that's ok. The postmaster is the one that should be in
>> control, not some subprocess.
>>
>> I fail to see the win in simplicity over using exit (like we already do
>> for the normal end of recovery!) is. The issue with the log line seems
>> perfectly easily to avoid by just checking the exit code in
>> postmaster.c.
>
> We need to be able to tell the difference between a crashed Startup
> process and this usage.
>
> As long as we can tell, I don't mind how we do it.
>
> Suggestions please.
>

Different exit code?

--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services