Re: PL/Python prepare example's use of setdefault

On 11/01/2014 12:13 PM, Peter Eisentraut wrote:
> On 10/15/14 5:58 PM, Jonathan Rogers wrote:
>> BTW, I would rewrite the 9.1 example to be shorter while
>> behaving the same:
>>
>>
>> CREATE FUNCTION usesavedplan() RETURNS trigger AS $$
>>     plan = SD.get("plan")
>>     if plan is None:
>
> If we're going for shortness, how about
>
>     if not plan:

Sure, that's fine as long as a plan object never looks Falsey.

>
> ?
>
>>         SD["plan"] = plan = plpy.prepare("SELECT 1")
>
> and here maybe
>
>     plan = SD["plan"] = plpy.prepare("SELECT 1")
>
> to emphasize the assignment to "plan"?

Yeah, order of assignment shouldn't matter.

>
>>     # rest of function
>> $$ LANGUAGE plpythonu;
>


--
Jonathan Ross Rogers