Re: Confused comment about drop replica identity index
От
Euler Taveira
Тема
Re: Confused comment about drop replica identity index
Дата
Msg-id
53e4a0d4-4b7b-4001-99c3-576bc03f73ef@www.fastmail.com
Ответ на
Re: Confused comment about drop replica identity index (Michael Paquier)
Список
Дерево обсуждения
Confused comment about drop replica identity index "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>
Re: Confused comment about drop replica identity index Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Re: Confused comment about drop replica identity index Michael Paquier <michael@paquier.xyz>
Re: Confused comment about drop replica identity index Alvaro Herrera <alvherre@alvh.no-ip.org>
Re: Confused comment about drop replica identity index Michael Paquier <michael@paquier.xyz>
Re: Confused comment about drop replica identity index "Euler Taveira" <euler@eulerto.com>
RE: Confused comment about drop replica identity index "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>
Re: Confused comment about drop replica identity index Michael Paquier <michael@paquier.xyz>
RE: Confused comment about drop replica identity index "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>
RE: Confused comment about drop replica identity index "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>
Re: Confused comment about drop replica identity index Michael Paquier <michael@paquier.xyz>
Re: Confused comment about drop replica identity index "Euler Taveira" <euler@eulerto.com>
RE: Confused comment about drop replica identity index "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>
On Mon, Dec 20, 2021, at 8:11 AM, Michael Paquier wrote:
On Mon, Dec 20, 2021 at 03:46:13AM +0000, wangw.fnst@fujitsu.com wrote:> Here is a patch to correct wrong comment about> REPLICA_IDENTITY_INDEX, And improve the pg-doc.That's mostly fine. I have made some adjustments as per theattached.
Your patch looks good to me.
Pondering more about this thread, I don't think we should change theexisting behavior in the back-branches, but I don't have any argumentsabout doing such changes on HEAD to help the features being workedon, either. So I'd like to apply and back-patch the attached, as afirst step, to fix the inconsistency.
What do you think about the attached patch? It forbids the DROP INDEX. We might
add a detail message but I didn't in this patch.
В списке pgsql-hackers по дате отправления
