Re: Support to define custom wait events for extensions

Поиск
Список
Период
Сортировка
От Masahiro Ikeda
Тема Re: Support to define custom wait events for extensions
Дата
Msg-id 53dc58793eb3df17d2da8c2fc2275fac@oss.nttdata.com
обсуждение исходный текст
Ответ на Re: Support to define custom wait events for extensions  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Support to define custom wait events for extensions  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Hi,

Thanks for your comments about the v2 patches. I updated to v3 patches.

The main changes are:
* remove the AddinShmemInitLock assertion
* add the new lock (WaitEventExtensionLock) to wait_event_names.txt
* change "static const int wee_hash_XXX_size" to "#define XXX"
* simplify worker_spi. I removed codes related to share memory and
   try to allocate the new wait event before waiting per background 
worker.
* change to elog from ereport because the errors are for developers.
* revise comments as advised.
* fix the request size for shared memory correctly
* simplify dblink.c
* fix process ordering of WaitEventExtensionNew() as advised to
   avoid leading illegal state.

In addition, I change the followings:
* update about custom wait events in sgml. we don't need to use
   shmem_startup_hook.
* change the hash names for readability.
  (ex. WaitEventExtensionNameHash -> WaitEventExtensionHashById)
* fix a bug to fail to get already defined events by names
   because HASH_BLOBS was specified. HASH_STRINGS is right since
   the key is C strings.

I create a new entry in commitfest for CI testing.
(https://commitfest.postgresql.org/44/4494/)

Thanks for closing the former entry.
(https://commitfest.postgresql.org/43/4368/)

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Yugo NAGATA
Дата:
Сообщение: Make psql's qeury canceling test simple by using signal() routine of IPC::Run
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: Incorrect handling of OOM in WAL replay leading to data loss