Re: Re: [COMMITTERS] pgsql: In checkpoint, move the check for in-progress xacts out of criti

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: Re: [COMMITTERS] pgsql: In checkpoint, move the check for in-progress xacts out of criti
Дата
Msg-id 533ECF1C.7040709@vmware.com
обсуждение исходный текст
Ответ на Re: [COMMITTERS] pgsql: In checkpoint, move the check for in-progress xacts out of criti  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
On 04/04/2014 06:06 PM, Robert Haas wrote:
> On Fri, Apr 4, 2014 at 10:32 AM, Heikki Linnakangas
> <heikki.linnakangas@iki.fi> wrote:
>> In checkpoint, move the check for in-progress xacts out of critical section.
>>
>> GetVirtualXIDsDelayingChkpt calls palloc, which isn't safe in a critical
>> section. I thought I covered this case with the exemption for the
>> checkpointer, but CreateCheckPoint is also called from the startup process.
>
> This commit un-broke "make check", which you might have wanted to run
> before committing, but "make -C src/test/isolation check" is still
> broken.

Yeah.. Fixed now.

- Heikki



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: Fwd: Proposal: variant of regclass
Следующее
От: Robert Haas
Дата:
Сообщение: Re: jsonb is also breaking the rule against nameless unions