Robert Haas <robertmhaas@gmail.com> writes:
> My suggestion is that we switch from using a List to marshal the data
> to using an ExtensibleNode. An advantage of that is that we'd have
> some in-core test coverage for the ExtensibleNode stuff. In theory it
> ought to be simpler and less messy, too, but I guess we'll find out.
Seems like a good idea, or at least one worth trying.
> Regardless of what approach we take, I disagree that this needs to be
> fixed in 9.6.
Agreed. This is only a cosmetic issue, and it's only going to be visible
to a very small group of people, so we can leave it alone until 9.7.
(FWIW, now that we've put in the list_make5 macros, I'd vote against
taking them out, independently of what happens in postgres_fdw.
Somebody else will need them someday, or indeed might already be
using them in some non-core extension.)
regards, tom lane