On 2020-05-25 17:57, Jonathan S. Katz wrote:
> I took a look over, it looks good. One question on the initdb.c diff:
>
> - if (strcmp(authmethodlocal, "scram-sha-256") == 0 ||
> - strcmp(authmethodhost, "scram-sha-256") == 0)
> - {
> - conflines = replace_token(conflines,
> - "#password_encryption = md5",
> - "password_encryption = scram-sha-256");
> - }
> -
>
> Would we reverse this, i.e. if someone chooses authmethodlocal to be
> "md5", we would then set "password_encryption = md5"?
Yeah, I was too enthusiastic about removing that. Here is a better patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services