On 02/01/2014 07:14 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> Copy the libpq DLL to the bin directory on Mingw and Cygwin.
> AFAICT, this patch set is completely broken.
>
> The buildfarm shows that every build attempt on the 8.4 branch has
> failed since it went in. This is because MKDIR_P isn't defined in
> that branch; you need to use $(mkinstalldirs) instead. However,
> the bigger problem is the fact that non-Windows platforms are even
> reaching that code; apparently, your if-logic is wrong. Testing
> shows that libpq.so is getting installed into the bindir in HEAD
> on my quite definitely not Windows system.
>
Argh!
OK, will fix.
cheers
andrew