On 01/30/2014 01:50 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 01/30/2014 01:03 PM, Hannu Krosing wrote:
>>> On 01/30/2014 06:45 PM, Andrew Dunstan wrote:
>>>> We'd have to move that code from hstore to jsonb_support.c and then
>>>> make hstore refer to it.
>>> Or just copy it and leave hstore alone - the code duplication is not
>>> terribly huge here and hstore might still want to develop independently.
>> We have gone to great deal of trouble to make jsonb and nested hstore
>> more or less incarnations of the same thing. The new hstore relies
>> heavily on the new jsonb. So what you're suggesting is the opposite of
>> what's been developed these last months.
> If so, why would you be resistant to pushing more code out of hstore
> and into jsonb?
>
I'm not. Above I suggested exactly that. I was simply opposed to Hannu's
suggestion that instead of making hstore refer to the adopted code we
maintain two copies of code that does essentially the same thing.
cheers
andrew