On 01/17/2014 12:55 PM, David Rowley wrote:
> On Sat, Jan 18, 2014 at 6:50 AM, Andrew Dunstan <andrew@dunslane.net
> <mailto:andrew@dunslane.net>> wrote:
>
>
> On 01/17/2014 12:43 PM, Tom Lane wrote:
>
> Andrew Dunstan <andrew@dunslane.net
> <mailto:andrew@dunslane.net>> writes:
>
> It looks like what we need to fix the immediate problem is
> to mark
> set_latch_on_sigusr1 with PGDLLIMPORT. Is that the only
> one of these
> symbols we might need to make visible?
>
> We've generally relied on the buildfarm to cue us to add
> PGDLLIMPORT.
> Add that one and see what happens ...
>
>
>
>
> OK, done.
>
>
> Great, that fixes it on my end.
>
> Thanks for fixing those.
Not quite out of the woods yet. We're getting this regression failure on
Windows/MSVC (see
<http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2014-01-17%2018%3A20%3A35>):
*** c:/prog/bf/root/HEAD/pgsql.2612/contrib/test_shm_mq/expected/test_shm_mq.out Fri Jan 17 13:20:53 2014
--- c:/prog/bf/root/HEAD/pgsql.2612/contrib/test_shm_mq/results/test_shm_mq.out Fri Jan 17 13:44:33 2014
***************
*** 5,18 **** -- internal sanity tests fail. -- SELECT test_shm_mq(32768, (select
string_agg(chr(32+(random()*96)::int),'') from generate_series(1,400)), 10000, 1);
! test_shm_mq
! -------------
!
! (1 row)
! SELECT test_shm_mq_pipelined(16384, (select string_agg(chr(32+(random()*96)::int), '') from
generate_series(1,270000)),200, 3);
! test_shm_mq_pipelined
! -----------------------
!
! (1 row)
!
--- 5,10 ---- -- internal sanity tests fail. -- SELECT test_shm_mq(32768, (select
string_agg(chr(32+(random()*96)::int),'') from generate_series(1,400)), 10000, 1);
! ERROR: queue size must be at least 472262143 bytes SELECT test_shm_mq_pipelined(16384, (select
string_agg(chr(32+(random()*96)::int),'') from generate_series(1,270000)), 200, 3);
! ERROR: queue size must be at least 472262143 bytes
cheers
andrew