On 01/16/2014 07:39 PM, Andrew Dunstan wrote:
>
> On 01/16/2014 01:57 PM, Peter Eisentraut wrote:
>> On 1/3/14, 9:00 PM, Andrew Dunstan wrote:
>>> Here is a patch for the new json functions I mentioned a couple of
>>> months ago. These are:
>>>
>>> json_to_record
>>> json_to_recordset
>>> json_object
>>> json_build_array
>>> json_build_object
>>> json_object_agg
>>>
>>> So far there are no docs, but the way these work is illustrated in the
>>> regression tests - I hope to have docs within a few days.
>> Compiler warnings:
>>
>> json.c: In function ‘json_object_two_arg’:
>> json.c:2210:5: warning: unused variable ‘count’ [-Wunused-variable]
>>
>> jsonfuncs.c: In function ‘json_to_record’:
>> jsonfuncs.c:1955:16: warning: unused variable ‘tuple’
>> [-Wunused-variable]
>> jsonfuncs.c:1953:18: warning: variable ‘rec’ set but not used
>> [-Wunused-but-set-variable]
>>
>> Also, please run your patch through git diff --check. I have noticed
>> that several of your patches have hilarious whitespace, maybe
>> something with your editor.
>>
>
>
> I'm happy to keep you amused. Some of this was probably due to cutting
> and pasting.
>
> all these issues are fixed in the attached patch.
In case anyone feels like really nitpicking, this version fixes some
pgindent weirdness due to an outdated typedef list in the previous version.
cheers
andrew