Re: [RFC] overflow checks optimized away

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: [RFC] overflow checks optimized away
Дата
Msg-id 52D7CE62.4040002@vmware.com
обсуждение исходный текст
Ответ на Re: [RFC] overflow checks optimized away  (Greg Stark <stark@mit.edu>)
Список pgsql-hackers
On 11/29/2013 04:04 AM, Greg Stark wrote:
> Attached is what I have so far. I have to say I'm starting to come
> around to Tom's point of view. This is a lot of hassle for not much
> gain. i've noticed a number of other overflow checks that the llvm
> optimizer is not picking up on so even after this patch it's not clear
> that all the signed overflow checks that depend on -fwrapv will be
> gone.
>
> This patch still isn't quite finished though.

In addition to what you have in the patch, Coverity is complaining about 
the overflow checks in int4abs (which is just like int8abs), and in 
DetermineTimeZoneOffset.

- Heikki



В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Следующее
От: Aidan Van Dyk
Дата:
Сообщение: Re: drop duplicate buffers in OS