Hi Michael,
Il 07/01/14 09:33, Michael Paquier ha scritto:
> I just had a quick look at v2, and it looks that the patch is in good
> shape.
Thanks.
> Sorry to be picky, but I am not sure that using the character m_type
> is adapted when delivering messages to pgstat facility. You might want
> to use a boolean instead...
I had had the same doubt, and opted for a more generic approach using a
char. I have followed your tip and made the field a boolean.
> MAX_XFN_CHARS is not adapted as well IMO: you should remove it and use
> instead MAXFNAMELEN of xlog_internal.h
Again, I had some concerns about redefining a constant (as MAX_XFN_CHARS
was defined only in pgarch.c). I wonder now if we should change this
behaviour too in pgarch.c (but that's a different patch).
Please find attached version 3.
I will update the commitfest page and add your previous message as
comment/review. I will tentatively add you as reviewer of the patch (as
well as Magnus).
Thanks,
Gabriele
--
Gabriele Bartolini - 2ndQuadrant Italia
PostgreSQL Training, Services and Support
gabriele.bartolini@2ndQuadrant.it | www.2ndQuadrant.it