Tested git apply and build again. No warnings.
The regression test also looks good to me now.
I'm done with this review.
(Not sure if I should move it to 'ready for committer' status or the CFM
should do).
// Antonin Houska (Tony)
On 12/06/2013 02:01 PM, Boszormenyi Zoltan wrote:
> 2013-12-04 14:51 keltezéssel, Boszormenyi Zoltan írta:
>> 2013-12-03 16:48 keltezéssel, Antonin Houska írta:
>>
>>> Tests - 23.patch
>>> ----------------
>>>
>>> src/interfaces/ecpg/test/sql/cursorsubxact.pgc
>>>
>>>
>>> /*
>>> * Test the implicit RELEASE SAVEPOINT if a SAVEPOINT
>>> * is used with an already existing name.
>>> */
>>>
>>> Shouldn't it be "... if a CURSOR is used with an already existing
>>> name?". Or just "... implicit RELEASE SAVEPOINT after an error"?
>>> I'd also appreciate a comment where exactly the savepoint is
>>> (implicitly) released.
>>
>> I have already answered this in my previous answer.
>
> And I was wrong in that. The comments in the test were rearranged
> a little and the fact in the above comment is now actually tested.
>
> Some harmless unused variables were also removed and an
> uninitialized variable usage was fixed. Because of these and the above
> changes a lot of patches need to be rebased.
>
> All patches are attached again for completeness.
>
> Best regards,
> Zoltán Böszörményi
>