Re: Skip hole in log_newpage

On 12/03/2013 01:37 PM, Andres Freund wrote:
> I haven't looked thoroughly through all callsites, but shouldn't the
> vacuumlazy callsite use std = true?

Well, it's logging an empty page, ie. a page full of zeros. I'm not sure 
if you'd consider that a "standard" page. Like the backup-block code in 
xlog.c, log_newpage actually makes a full page image without the hole if 
pd_lower == 0, even if you pass std = 'true', so the end result is the same.

- Heikki