Re: WITHIN GROUP patch

Поиск
Список
Период
Сортировка
От Vik Fearing
Тема Re: WITHIN GROUP patch
Дата
Msg-id 52788E15.7020802@dalibo.com
обсуждение исходный текст
Ответ на Re: WITHIN GROUP patch  (Atri Sharma <atri.jiit@gmail.com>)
Ответы Re: WITHIN GROUP patch  (Atri Sharma <atri.jiit@gmail.com>)
Список pgsql-hackers
On 11/04/2013 08:43 AM, Atri Sharma wrote:
> Please find attached our latest version of the patch. This version
> fixes the issues pointed out by the reviewers.

No, it doesn't.  The documentation still contains formatting and
grammatical errors, and the code comments still do not match the their
surroundings.  (The use of "I" in the code comments is a point I have
conceded on IRC, but I stand by my other remarks.)

Don't bother submitting a new patch until I've posted my technical
review, but please fix these issues on your local copy.

-- 
Vik




В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Arulappan, Arul Shaji"
Дата:
Сообщение: Re: UTF8 national character data type support WIP patch and list of open issues.
Следующее
От: David Rowley
Дата:
Сообщение: Re: logical column order and physical column order