Kris,
Here is that patch again, correct without any formatting or whitespace
changes (white space was ignored in the diff). Let me know if this is
better then the last one.
-Andy
On May 5, 2004, at 3:46 PM, Kris Jurka wrote:
>
>
> On Wed, 5 May 2004, Andy Zeneski wrote:
>
>> Kris,
>>
>> Here it is again, I think my IDE reformatted a few classes which
>> caused
>> this patch to be bigger then it needed to be. Here it is in its
>> current
>> state.
>>
>> If the formatting is major problem, I can attempt to reformat it to
>> desired settings. I will need to know what the "preferred" way is.
>> I've
>> noticed there are several different formats used within these classes,
>> I could easily run the tree though Jacobe and clean it up. However,
>> that may be too big for the list. :)
>
> The formatting is an issue. Yes, the code is formatted differently all
> over the driver, but now is not the time to fix that. There are too
> many
> outstanding patches that will conflict with these whitespace changes to
> try and do something about that now. I aim to reindent/reformat at the
> start of 7.5 beta when there shouldn't be many outstanding patches or
> active development.
>
> Also just trying to read your patch is difficult because it is
> impossible
> to tell if a real change is mixed in with a whitespace change. Could
> you
> resubmit this patch as just your changes.
>
> Kris Jurka
>
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if
> your
> joining column's datatypes do not match