Re: Department of Redundancy Department: makeNode(FuncCall) division

On 6/28/13 11:30 AM, Robert Haas wrote:
> On Fri, Jun 28, 2013 at 10:31 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> David Fetter <david@fetter.org> writes:
>>> Please find attached the latest patch.
>>
>> I remain of the opinion that this is simply a bad idea.  It is unlike
>> our habits for constructing other types of nodes, and makes it harder
>> not easier to find all the places that need to be updated when adding
>> another field to FuncCall.
> 
> I think it's a nice code cleanup.  I don't understand your objection.

Yeah, I was reading the patch thinking, yes, finally someone cleans that up.