On 5/21/13 2:41 PM, Bruce Momjian wrote:
> I have thought about this and there are potentially several options
> specified to pg_upgrade that could be passed into scripts:
>
> -O, --new-options=OPTIONS new cluster options to pass to the server
> -P, --new-port=NEWPORT new cluster port number (default 50432)
> -u, --user=NAME cluster superuser (default "root")
>
> However, if we pass these items into the scripts, we then force these
> values to be used, even if the user wants to use a different value. It
> is a balance between supplying defaults vs. requiring the user to supply
> or change the values used during the ugprade.
>
> At this point, I have favored _not_ supplying defaults in the script.
> Do you have an alternative argument in favor of supplying defaults?
You could put environment variable assignments at the top of the script,
so they are easy to change or remove. But it seems to me the values
should be in there somehow.