Re: Confusing comment in xlog.c or am I missing something?

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: Confusing comment in xlog.c or am I missing something?
Дата
Msg-id 51820734.4030808@vmware.com
обсуждение исходный текст
Ответ на Re: Confusing comment in xlog.c or am I missing something?  (Amit Langote <amitlangote09@gmail.com>)
Ответы Re: Confusing comment in xlog.c or am I missing something?
Список pgsql-hackers
Дерево обсуждения 
On 02.05.2013 09:11, Amit Langote wrote:
> In that case, should the comment be "/* Check for crossing of xlog
> file boundary */"
> instead of  /* Check for crossing of xlog segment boundary */, since
> ( RecPtr->xrecoff>= XLogFileSize )
> would mean crossing the xlog "file" (not segment) boundary, right?

Yeah, that would be more correct. The phrase we seem to use elsewhere in 
xlog.c is "crossing a logid boundary".

- Heikki

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Langote
Дата:
Сообщение: Re: Confusing comment in xlog.c or am I missing something?
Следующее
От: Pavan Deolasee
Дата:
Сообщение: Re: Confusing long option in pg_receivexlog/basebackup/dumpall