Though not the original patch autor, I did modify and submit it to the
CF app, so I'll reply here :)
On 10/12/12 19:20, Karl O. Pinc wrote:
> On 12/09/2012 10:33:59 PM, Karl O. Pinc wrote:
> I've gone ahead and signed up to review this patch.
Thanks!
> There were 2 outstanding issue raised:
>
> Is this useful enough/proceeding in the right direction to commit
> now?
I believe the process would be to mark it as "Ready for Committer" if
you feel like it's ready and a then a committer would make the final call.
> Should some of the logic be moved out of a subroutine and into the
> calling code?
I think I structured the PLy_get_spi_sqlerrcode to accept the same kind
of arguments as PLy_get_spi_error_data, which means a SPIException
object and a pointer to whatever values it can fill in.
That said, I haven't really thought about that too much, so I'm
perfectly fine with moving that bit of logic to the caller.
Cheers,
Jan