Re: [BUG] False indication in pg_stat_replication.sync_state

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: [BUG] False indication in pg_stat_replication.sync_state
Дата
Msg-id 50AFB9C1.5000806@vmware.com
обсуждение исходный текст
Ответ на Re: [BUG] False indication in pg_stat_replication.sync_state  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 23.11.2012 19:55, Tom Lane wrote:
> Heikki Linnakangas<hlinnakangas@vmware.com>  writes:
>> Committed, thanks.
>
> Doesn't seem to have been pushed to master?

On purpose. Per commit message:

> 9.3 doesn't have this problem because XLogRecPtr is now a single 64-bit
> integer, so XLogRecPtrIsInvalid() does the right thing. Apply to 9.2, and
> 9.1 where pg_stat_replication view was introduced.

I considered applying it to master anyway, just to keep the branches in 
sync. But XLogRecPtrIsInvalid(var) seems slightly more readable than 
XLByteEQ(var, InvalidXLogRecPtr), so I decided not to.

- Heikki



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [BUG] False indication in pg_stat_replication.sync_state
Следующее
От: Josh Kupershmidt
Дата:
Сообщение: Re: Suggestion for --truncate-tables to pg_restore