Re: [PATCH] Perform check for oversized WAL record before calculating record CRC

Поиск
Список
Период
Сортировка
От Andrey Borodin
Тема Re: [PATCH] Perform check for oversized WAL record before calculating record CRC
Дата
Msg-id 509B5624-091E-45F9-B0D9-84DDE2C6CB94@yandex-team.ru
обсуждение исходный текст
Ответ на [PATCH] Perform check for oversized WAL record before calculating record CRC  (Sergey Fukanchik <s.fukanchik@postgrespro.ru>)
Ответы Re: [PATCH] Perform check for oversized WAL record before calculating record CRC
Список pgsql-hackers

> On 6 Sep 2025, at 16:00, Sergey Fukanchik <s.fukanchik@postgrespro.ru> wrote:
>
> <0001-Perform-check-for-oversized-WAL-record-before-calcul.patch>

Hi Sergey!

It seems to me reasonable to move size check above CRC computation. However, it seems suspicious to me to run a test
thatallocates 1Gb in `make check`. Maybe, there are places that are not exercised too often. Perhaps recovery tests or
somethinglike that. 


Best regards, Andrey Borodin.


В списке pgsql-hackers по дате отправления: