Re: BUG #18974: Postgresql repeatable crash after pg_upgrade from 15 to 17.5 version in postgresql_fdw queries

Hello

Yeah, I think there is a missing copy of the type field:

--- a/src/interfaces/libpq/fe-cancel.c
+++ b/src/interfaces/libpq/fe-cancel.c
@@ -119,6 +119,7 @@ PQcancelCreate(PGconn *conn)
         goto oom_error;
 
     originalHost = conn->connhost[conn->whichhost];
+    cancelConn->connhost[0].type = originalHost.type;
     if (originalHost.host)
     {
         cancelConn->connhost[0].host = strdup(originalHost.host);

Other fields of the pg_conn_host structure are copied below in the code, excepts type.

regards, Sergei