On 09/05/2012 09:11 AM, Bruce Momjian wrote:
>
> I reviewed this idea and supports this patch's inclusion in 9.2. I was
> unclear why it was needed, but I see pg_dumpall, which is the file
> pg_upgrade splits apart, as also using binary mode to write this file:
>
> OPF = fopen(filename, PG_BINARY_W);
>
> I agree with Tom that pg_upgrade needs some quiet time. ;-) Andrew,
> have a sufficient number of buildfarm members verified our recent
> patches that this can be added. My patch from last night was mostly C
> comments so isn't something that needs testing.
I am quite happy not committing anything for now.
There are two buildfarm members doing pg_upgrade tests: crake (Fedora
16) and pitta (Windows/Mingw64). The buildfarm code is experimental and
not in any release yet, and when it is the test will be optional.
The PG_BINARY_W change has only been verified on a non-buildfarm setup
on my laptop (Mingw)
Note that while it does look like there's a bug either in pg_upgrade or
pg_dumpall, it's probably mostly harmless (adding some spurious CRs to
function code bodies on Windows). I'd feel happier if it didn't, and
happier still if I knew for sure the ultimate origin. Your pg_dumpall
discovery above is interesting. I might have time later on today to
delve into all this. I'm out of contact for the next few hours.
cheers
andrew