Re: State of the QNX Port

Am 17:24 01.03.01 +0100 schrieb Peter Eisentraut:
>Tegge, Bernd writes:
>
> > * config/prep_buildtree :
> >    * caused configure to exit, because the QNX shell may or may not return
> >      an exit code of 0 if a script just ends without an exit statement.
> >      added an 'exit 0' as last line
>
>Okay.
>
> >    * the script  called from configure replaced all Makefiles with
> >      symlinks to themselves. This is because configure notices a difference
> >      between $abs_top_builddir and $abs_top_srcdir. However they are the
> >      same; the former just contains a net absolute path (i.e. has a
> >      //<node> prefix ). This might also happen if the path contains a
> >      symlink that is being resolved in one of the variables.
> >      probably QNX specific
>
>I'm not sure I believe that.  We have
>
>abs_top_srcdir=`cd $srcdir && pwd`
>abs_top_builddir=`pwd`
>
>($srcdir should be '.' in most cases.)  prep_buildtree is called only if
>those are different.  This should not happen unless your pwd program has a
>behaviour I've never heard of.  Please investigate.

Believe it :-) I put a 'set -x' in front of the comparison and saw the
difference. Here are the relevant parts from configure:

repas@qnx4[7]:ttypd$ pwd
/CVStrees/pgsql
repas@qnx4[7]:ttypd$ ./configure
+ test -z
+ ac_srcdir_defaulted=yes
+ ac_prog=//7/part2/CVStrees/pgsql/configure
+ print //7/part2/CVStrees/pgsql/configure
+ sed s%/[^/][^/]*$%%
+ ac_confdir=//7/part2/CVStrees/pgsql
+ test x//7/part2/CVStrees/pgsql = x//7/part2/CVStrees/pgsql/configure
+ srcdir=//7/part2/CVStrees/pgsql
+ test ! -r //7/part2/CVStrees/pgsql/src/backend/access/common/heaptuple.c
+ test ! -r //7/part2/CVStrees/pgsql/src/backend/access/common/heaptuple.c
+ print //7/part2/CVStrees/pgsql
+ sed s%\([^/]\)/*$%\1%
+ srcdir=//7/part2/CVStrees/pgsql
+ set +x
loading cache ./config.cache
...
checking for nsgmls... no
+ test x//7/part2/CVStrees/pgsql != x/CVStrees/pgsql
+ print preparing build tree... \c
preparing build tree... + /bin/sh
//7/part2/CVStrees/pgsql/config/prep_buildtree
  //7/part2/CVStrees/pgsql /CVStrees/pgsql
+ print done
done
+ set +x




> > * The shell command for remove-old-headers in ~/src/include/Makefile gave a
> >    syntax error, because of a missing semicolon:
>
>Okay.
>
> > * missing -lz in ~/src/bin/pg_dump/Makefile for pg_dump and pg_restore.
> >    pg_dump and pg_restore make calls into the zlib, but have no -lz in the
> >    link command.
>
>-lz should be found by configure and should be in the LIBS variable.
>Look for lines
>
>checking for zlib.h... yes
>checking for inflate in -lz... yes
>
>when configuring.  As you seemingly do have libz installed, maybe you
>could check in config.log why they're not found.

They *are* found. I see the above lines when configure runs. config.log
shows no errors for zlib.h and inflate. I still get link errors if I don't
add '-lz' manually. Should I put it in '~src/makefiles/Makefile.qnx4' ?

> > - replacement ~/src/backend/port/dynloader/qnx4.h
> >    (clashed with the new fmgr code )
>
>Can you explain the nature of the "clash"?  I don't follow your change
>offhand.

Well, the contents of the previous version were practically identical to
dynamic_loader.h, except that fmgr.h was not included before the function
declarations. That led to compile errors in dfmgr.c and fmgr.c because
PGFunction was not declared.


>--
>Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/