Re: meson missing test dependencies

Hi,

On 2024-12-05 20:08:24 +0100, Peter Eisentraut wrote:
> On 03.12.24 17:01, Andres Freund wrote:
> > On 2024-12-02 11:10:56 +0100, Peter Eisentraut wrote:
> > That's unfortunately a very partial fix - because we insist on tests being run
> > against a temporary install, we don't just need to rebuild the code, we also
> > need to re-install it.  Without that you don't, e.g., see server changes.
> 
> Right, I was willing to accept that as a compromise, but see below.
> 
> > However, it looks like the tmp_install test *does* miss dependencies too and I
> > see no reason to not fix that.
> 
> > diff --git i/meson.build w/meson.build
> > index ff3848b1d85..55b751a0c6b 100644
> > --- i/meson.build
> > +++ w/meson.build
> > @@ -3263,6 +3263,7 @@ test('tmp_install',
> >       priority: setup_tests_priority,
> >       timeout: 300,
> >       is_parallel: false,
> > +    depends: all_built,
> >       suite: ['setup'])
> > 
> >   test('install_test_files',
> 
> Yes, that addresses my cube example.

Let's do that. I'm inclined to only do so on master, but I can also see
backpatching it. Arguments?


> But it doesn't address the test_json_parser example, because in that case
> the test executables are not installed.  So in that case we still need to
> manually add the dependencies.  But those are only a few cases (maybe just
> test_json_parser and libpq_pipeline).

Agreed!

Greetings,

Andres Freund