Re: I: About "Our CLUSTER implementation is pessimal" patch
| От | Josh Kupershmidt |
|---|---|
| Тема | Re: I: About "Our CLUSTER implementation is pessimal" patch |
| Дата | |
| Msg-id | 4ec1cf761002090816j4879f391p7a0bb03fadd40da7@mail.gmail.com обсуждение |
| Ответ на | I: About "Our CLUSTER implementation is pessimal" patch (Leonardo F <m_lists@yahoo.it>) |
| Ответы |
Re: I: About "Our CLUSTER implementation is pessimal" patch
Re: I: About "Our CLUSTER implementation is pessimal" patch |
| Список | pgsql-hackers |
On Tue, Feb 9, 2010 at 5:49 AM, Leonardo F <m_lists@yahoo.it> wrote:
Hi Leonardo,
Perhaps you could supply a .sql file containing a testcase illustrating the performance benefits you tested with your patch -- as I understand, the sole purpose of this patch is to speed up CLUSTER -- along with your results? The existing src/test/regress/sql/cluster.sql looks like it only has some basic sanity checks in it, and not performance tests. An idea of what hardware you're testing on and any tweaks to postgresql.conf might be useful as well.
I was able to apply your patch cleanly and run CLUSTER with it, and "make check" passed for me on OS X as well.
Hope this helps, and sorry I'm not able to offer more technical advice on your patch.
Josh
Not even a comment? As I said, performance results on my system
were very good....
Hi Leonardo,
Perhaps you could supply a .sql file containing a testcase illustrating the performance benefits you tested with your patch -- as I understand, the sole purpose of this patch is to speed up CLUSTER -- along with your results? The existing src/test/regress/sql/cluster.sql looks like it only has some basic sanity checks in it, and not performance tests. An idea of what hardware you're testing on and any tweaks to postgresql.conf might be useful as well.
I was able to apply your patch cleanly and run CLUSTER with it, and "make check" passed for me on OS X as well.
Hope this helps, and sorry I'm not able to offer more technical advice on your patch.
Josh
В списке pgsql-hackers по дате отправления: