On 14.03.24 01:26, Michael Paquier wrote:
> -EventTriggerSupportsObjectClass(ObjectClass objclass)
> +EventTriggerSupportsObject(const ObjectAddress *object)
>
> The shortcut introduced here is interesting, but it is inconsistent.
> HEAD treats OCLASS_SUBSCRIPTION as something supported by event
> triggers, but as pg_subscription is a shared catalog it would be
> discarded with your change. Subscriptions are marked as supported in
> the event trigger table:
> https://www.postgresql.org/docs/devel/event-trigger-matrix.html
Ah, good catch. Subscriptions are a little special there. Here is a
new patch that keeps the switch/case arrangement in that function. That
also makes it easier to keep the two EventTriggerSupports... functions
aligned. Also added a note about subscriptions and a reference to the
documentation.