Re: BUG #6643: [PostgreSQL9.2beta1] COPY after changing fillfactor gets a PANIC.

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: BUG #6643: [PostgreSQL9.2beta1] COPY after changing fillfactor gets a PANIC.
Дата
Msg-id 4FB38C29.8070009@enterprisedb.com
обсуждение исходный текст
Ответ на Re: BUG #6643: [PostgreSQL9.2beta1] COPY after changing fillfactor gets a PANIC.  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Ответы Re: BUG #6643: [PostgreSQL9.2beta1] COPY after changing fillfactor gets a PANIC.
Список pgsql-bugs
On 16.05.2012 13:47, Heikki Linnakangas wrote:
> This sounds like a bug in the new page-at-a-time behavior in COPY. Can
> you send me a self-contained test, including the test data?

Never mind. After staring at the code for a while, I spotted the bug,
and was able to reproduce with a simpler case. It's quite easy to
reproduce when you set fillfactor even lower, like 10.

The problem is with this line in heap_multi_insert function:

    if (PageGetHeapFreeSpace(page) - saveFreeSpace < MAXALIGN(heaptup->t_len))

That doesn't work as intended, because the return value of
PageGetHeapFreeSpace and saveFreeSpace are unsigned. When saveFreeSpace
is larger than the amount of free space on the page, the left hand side
of that comparison is supposed to go negative, but it wraps around to a
highly positive number because it's unsigned.

Fixed, thanks for the report!

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: BUG #6643: [PostgreSQL9.2beta1] COPY after changing fillfactor gets a PANIC.
Следующее
От: Tomonari Katsumata
Дата:
Сообщение: Re: BUG #6643: [PostgreSQL9.2beta1] COPY after changing fillfactor gets a PANIC.