On 03/28/2012 09:12 PM, Joachim Wieland wrote:
> On Thu, Mar 29, 2012 at 2:46 AM, Andrew Dunstan<andrew@dunslane.net> wrote:
>> But your patch hasn't got rid of them, and so it's declared twice. There is
>> no pgpipe.h, BTW, it's declared in port.h. If VC2005 doesn't complain about
>> the double declaration then that's a bug in the compiler, IMNSHO. Doesn't it
>> even issue a warning? I no longer use VC2005 for anything, BTW, I use VC2008
>> or later.
> I agree, the compiler should have found it, but no, I don't even get a
> warning. I just verified it and when I add a #error right after the
> prototypes in port.h then it hits the #error on every file, so it
> definitely sees both prototypes and doesn't complain... cl.exe is
> running with /W3.
>
> src/bin/pg_dump/pg_backup_archiver.c
>> Anyway, ISTM the best thing is just for us to get rid of pgpipe without
>> further ado. I'll try to get a patch together for that.
> Thanks.
OK, I have committed this. Following that, you need to add a couple of
macros for pipewrite to parallel.c. There's also a missing cast in the
call to beginthreadex().
I'll continue testing tomorrow.
cheers
andrew