Peter Geoghegan <peter@2ndquadrant.com> wrote:
> Magnus Hagander <magnus@hagander.net> wrote:
>> from postgresql.conf.sample:
>>
>> #replication_timeout = 60s # in milliseconds; 0 disables
>>
>> Seconds or milliseconds? I would suggest we just remove the "in
>> milliseconds", and instead say "timeout for replication
>> connections; 0 disables".
>
> +1 from me. That's very confusing.
Isn't it providing information on both the granularity and the
default unit if none is specified? Why is it more confusing here
than statement_timeout or any of the other places this pattern is
followed?
-1 from me on removing it *only* here.
-Kevin