On 18/12/11 20:53, Peter Eisentraut wrote:
> On tis, 2011-12-06 at 00:58 +0100, Jan Urbański wrote:
>> Rebased against master after the SPI cursor patch has been committed.
>>
>> The first patch removes SPI boilerplate from the cursor functions as
>> well and the second patch creates a plpython_cursor.c file.
>>
>> A side effect of creating a separate file for cursors is that I had to
>> make PLy_spi_transaction_{begin,commit,abort} helper functions external
>> since they're used both by regular SPI execution functions and the
>> cursor functions.
>>
>> They live the plpython_spi.c which is not an ideal place for them, but
>> IMHO it's not bad either.
>
> Committed now.
Great, thanks! I hope this will make for a more maintanable PL/Python.
By the way, the buildfarm is turning red because it's missing the
attached patch.
Cheers,
Jan