Re: Checkpointer write combining
| От | Chao Li |
|---|---|
| Тема | Re: Checkpointer write combining |
| Дата | |
| Msg-id | 4ECED07F-75F2-46D4-8F71-0B0DFA350777@gmail.com обсуждение исходный текст |
| Ответ на | Re: Checkpointer write combining (Melanie Plageman <melanieplageman@gmail.com>) |
| Ответы |
Re: Checkpointer write combining
|
| Список | pgsql-hackers |
> On Nov 19, 2025, at 02:49, Melanie Plageman <melanieplageman@gmail.com> wrote: > > I no longer remember why I made that patch WIP, so I've removed that > designation. I just reviewed 0007. It removes the second parameter "bool skip_recently_used” from SyncOneBuffer. The function is staticand is only called in one place with skip_recently_used=true, thus removing the parameter seems reasonable, and withoutconsidering pinned buffer, the function is simplified a little bit. I only got a tiny comment: ``` + * We can make these check without taking the buffer content lock so ``` As you changed “this” to “these”, “check” should be changed to “checks” accordingly. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
В списке pgsql-hackers по дате отправления: