Re: REVIEW: Optimizing box_penalty

On 08.10.2011 21:51, Kevin Grittner wrote:
> I tried to review the "Optimizing box_penalty" patch:

Thanks!

> On the other hand, this patch leaves the code a few lines shorter and
> eliminates some unnecessary Datum wrapping, PG_FUNCTION_ARGS
> parameters on a static function, and allows that function to be
> called directly rather than using DirectFunctionCall2().  I find the
> resulting code a little cleaner and easier to read.  I would prefer
> to see it applied on that basis, personally.

Agreed, committed.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com