Re: BUG #6216: Calling PQconnectdbParams from C++ with a char**

On 21/09/2011 4:25 PM, Lionel Elie Mamane wrote:
> I added my initial patch, and as far as I understand, I have to send
> the revised patch to the list before I can register it at the
> commitfest. So here is my revised patch, that uses "const char *const * "
> like elsewhere in the same file instead of "char const* const*".

Yep, I'm happy with that. It does what it says and no more.

I have *NOT* done any detailed testing, as I'm in the middle of moving
house, but I find it hard to see how it can break anything that isn't
its self incorrect. You can still pass a `char *' to a `const char *
const' param, so it won't break any call sites.

--
Craig Ringer