RE: ON CONFLICT DO NOTHING on pg_dump
| От | Ideriha, Takeshi |
|---|---|
| Тема | RE: ON CONFLICT DO NOTHING on pg_dump |
| Дата | |
| Msg-id | 4E72940DA2BF16479384A86D54D0988A6F14E20F@G01JPEXMBKW04 обсуждение исходный текст |
| Ответ на | Re: ON CONFLICT DO NOTHING on pg_dump (Thomas Munro <thomas.munro@enterprisedb.com>) |
| Ответы |
Re: ON CONFLICT DO NOTHING on pg_dump
|
| Список | pgsql-hackers |
Hi, thanks for the revision.
>
>+ Add ON CONFLICT DO NOTHING clause in the INSERT commands.
>
>I think this would be better as: Add <literal>ON CONFLICT DO NOTHING</literal> to
><command>INSERT</command> commands.
Agreed.
>+ printf(_(" --on-conflict-do-nothing dump data as INSERT
>commands with ON CONFLICT DO NOTHING \n"));
>
>That's slightly misleading... let's just use the same wording again, eg "add ON
>CONFLICT DO NOTHING to INSERT commands".
Agreed. But you forgot fixing it at pg_dump.c.
So could you please fix this and commit it?
Regards,
Takeshi Ideriha
В списке pgsql-hackers по дате отправления: