Re: [COMMITTERS] pgsql: Adjust OLDSERXID_MAX_PAGE based on BLCKSZ.

Heikki Linnakangas  wrote:
> I'm getting a bunch of warnings on Windows related to this:
>> .\src\backend\storage\lmgr\predicate.c(768): warning C4307: '+' :
>>    integral constant overflow
The part of the expression which is probably causing this: (MaxTransactionId + 1) / OLDSERXID_ENTRIESPERPAGE - 1
Which I fear may not be getting into overflow which will not do the
right thing even where there is no warning.  :-(
Would it be safe to assume that integer division would do the right
thing if we drop both of the "off by one" adjustments and use?: MaxTransactionId / OLDSERXID_ENTRIESPERPAGE
-Kevin