Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

On 06/19/2011 08:00 AM, Bruce Momjian wrote:
> Tom Lane wrote:
>> Bruce Momjian<bruce@momjian.us>  writes:
>>> Perhaps we should recommend:
>>>     cd /path&&  test ! -f %f&&  cp %p %f
>>> That is shorter and removes the duplicate problem.
>> Um ... %p is relative to the database directory.
> Oh, I see now.  I had thought it was an absolute path, but good thing it
> isn't because of the possible need for quoting characters in the path
> name.
>
> The only other idea I have is:
>
>     NEW=/path&&  test ! -f $NEW/%f&&  cp %p $NEW/%f
>
> but that is not going to work with csh-based shells, while I think the
> original is fine.

Isn't this invoked via system()? AFAIK that should always invoke a 
Bourne shell or equivalent on Unix. But in any case, I think you're 
trying to solve a problem that doesn't really exist.

cheers

andrew