On 06/15/2011 04:49 PM, Josh Berkus wrote:
> You do not have to be a C coder to be a patch reviewer. Pretty much all
> you need to know is:
> - how to checkout PostgreSQL from Git
> - how to build PostgreSQL from source
> - how to apply a patch
>
And you don't even really need to know these things well. If you're on
a UNIX system that has git installed, here's a complete example of how
to build a custom PostgreSQL that includes a patch for review:
cd
git clone git://github.com/gregs1104/peg.git
export PATH="$HOME/peg:$PATH"
mkdir pgwork
peg init test
cd pgwork/src/test
patch -p1 < ~/mytest.patch
. peg build
psql
Just substitute the name of the patch you're using in the "patch" step
here, and if it applies correctly (one of the first things patch review
intends to test for) you're done. This does a local installation of
PostgreSQL into a tree under your home directory, with reasonable
defaults for all of the parts related to downloading the source code and
compiling it. See the documentation for the peg utility at
https://github.com/gregs1104/peg for more examples
--
Greg Smith 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.us
"PostgreSQL 9.0 High Performance": http://www.2ndQuadrant.com/books