On 07.06.2011 20:03, Kevin Grittner wrote:
> Heikki Linnakangas<heikki.linnakangas@enterprisedb.com> wrote:
>
>> We've also already removed the reserved entry for scratch space
>
> This and Tom's concerns have me wondering if we should bracket the
> two sections of code where we use the reserved lock target entry
> with HOLD_INTERRUPTS() and RESUME_INTERRUPTS().
That's not necessary. You're holding a lwlock, which implies that
interrupts are held off already. There's a HOLD_INTERRUPTS() call in
LWLockAcquire and RESUME_INTERRUPTS() in LWLockRelease.
-- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com