Tom Lane wrote:
> Yeah, I was thinking that it'd be better to pull it out of
> GetNewTransactionId and put it in a higher level.
As long as it is always called when an xid is assigned. Since this
function appears to be on the only path to that, it should be fine.
> No strong preference about where in AssignTransactionId to put it.
> Is there any chance that it would be significant whether we do it
> before or after taking the lock on the XID (XactLockTableInsert)?
No, but since we need to do it only on a top level assignment, we
could save a couple cycles by putting it on an else on line 456.
-Kevin