On 22.03.2011 01:06, Tom Lane wrote:
> Heikki Linnakangas<heikki.linnakangas@enterprisedb.com> writes:
>> Any objections to the 2nd attached patch, which adds the mapping of
>> those locale names on Windows?
>
> I think the added initdb message isn't following our style guidelines
> --- it certainly doesn't match the adjacent existing message. Other
> than that quibble, ok here.
What you usually get is something like this:
> ...
> The database cluster will be initialized with locale Lithuanian_Lithuania.1257.
> The default database encoding has accordingly been set to WIN1257.
> initdb: could not find suitable text search configuration for locale Lithuanian_
> Lithuania.1257
> The default text search configuration will be set to "simple".
>
> creating directory data2 ... ok
> creating subdirectories ... ok
> ...
And when initdb falls back to UTF-8 with the patch you get:
> The database cluster will be initialized with locale Chinese (Simplified)_China.936.
> Encoding GBK implied by locale is not allowed as a server-side encoding.
> The default database encoding has been set to UTF8 instead.
> initdb: could not find suitable text search configuration for locale Chinese (Simplified)_China.936
> The default text search configuration will be set to "simple".
>
> creating directory data2 ... ok
> creating subdirectories ... ok
> ...
The new message fits in nicely with the surrounding messages IMHO. Or
are you thinking that it should be more warning like, similar to the
message about missing text search configuration? Something like:
> The database cluster will be initialized with locale Chinese
(Simplified)_China.936.> initdb: encoding GBK implied by locale is not allowed as a
server-side encoding.> The default database encoding has been set to UTF8 instead.> initdb: could not find suitable
textsearch configuration for locale
Chinese (Simplified)_China.936> The default text search configuration will be set to "simple".>> creating directory
data2... ok> creating subdirectories ... ok> ...
That's fine with me as well..
-- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com