On 22/02/11 22:48, Peter Eisentraut wrote:
> Committed this, with two changes: Changed some things around with the
> way const char * is propagated. Just casting it away is not nice. Also
> dropped the error tests in the _quote.sql regression test. This
> generates three different wordings of error messages from Python with
> 2.6, 3.1, and 3.2, which I don't care to maintain. Maybe one day we'll
> have a better solution for this.
Thanks.
One thing: you removed the conditional pfree from PLy_quote_ident, which
makes this function leak memory if the actual quoting took place, no? Is
that leak too small to worry about?
Cheers,
Jan