On 6.2.2011 08:17, Greg Smith wrote:
> Below is what changed since the last posted version, mainly as feedback
> for Tomas:
>
> -Explained more clearly that pg_stat_reset and
> pg_stat_reset_single_counters will both touch the database reset time,
> and that it's initialized upon first connection to the database.
>
> -Added the reset time to the list of fields in pg_stat_database and
> pg_stat_bgwriter.
>
> -Fixed some tab/whitespace issues. It looks like you had tab stops set
> at 8 characters during some points when you were editing non-code
> files. Also, there were a couple of spot where you used a tab while
> text in the area used spaces. You can normally see both types of errors
> if you read a patch, they showed up as misaligned things in the context
> diff.
>
> -Removed some extra blank lines that didn't fit the style of the
> surrounding code.
>
> Basically, all the formatting bits I'm nitpicking about I found just by
> reading the patch itself; they all stuck right out. I'd recommend a
> pass of that before submitting things if you want to try and avoid those
> in the future.
Thanks for fixing the issues and for the review in general. I have to
tune the IDE a bit to produce the right format and be a bit more careful
when creating the patches.
regards
Tomas