Jeff Davis <pgsql@j-davis.com> wrote:
> Really, I think this should be using HTSV to separate concerns
> better and improve readability. My first reaction was to try to
> find out what the function was doing that's special. If it is
> doing something special, and HTSV is not what you're really
> looking for, a comment to explain would be helpful.
It does seem that at least a comment would be needed. I'm not at
all confident that there isn't some macro or function which would
yield what I need. I just sent an email clarifying exactly what I
want to check, so if you can see a better way to determine that, I'm
all ears.
> As an example, consider that Robert Haas recently suggested using
> an infomask bit to mean frozen, rather than actually removing the
> xid, to save the xid as forensic information. If that were to
> happen, your code would be reading an xid that may have been
> re-used.
Yeah, clearly if the code remains as it is, it would be sensitive to
changes in how hint bits or the xid values are used. If we can
abstract that, it's clearly a Good Thing to do so.
-Kevin